Combining Ros repos, and getting onto ROS index
Hi all,
I am looking to continue supporting getting the ROS2 drivers into the ROS index. Currently only the docs are on the index, https://index.ros.org/r/ar4_ros_driver/#jazzy and https://github.com/ros/rosdistro/blob/master/jazzy/distribution.yaml#L546. I was wondering if it would be possible to update it to be the Annin-Robotics github src and then go from there.
There's also the second ros github, https://anninrobotics.com/ros2/, for isaac sim. I was thinking maybe they could all be combined? I would love to contribute, and help out with this effort!
Thanks for offering to help. The Annin-Robotics repository was originally forked from ycheng517's work and has become the repository I'm currently maintaining and directing users toward. Updating the ROS Index to point to the Annin-Robotics repository sounds like a reasonable next step. I'm not very familiar with the ROS Index and release process, so I'd be interested in hearing what changes would be required and what benefits users would see. The Isaac Sim repository is maintained separately by Ekumen, so my initial thought would be to keep those projects separate and cross-reference them rather than merge them, but I'm certainly open to discussion.
Chris Annin Yeah, sounds good, it seems like for the ROS index most of the work is done in the setup and then there is some automation that auto updates packages whenever updates are available...still trying to understand that part.
https://docs.ros.org/en/jazzy/How-To-Guides/Releasing/Releasing-a-Package.html is basically the starting point, what Yifei has done is basically step 1, however I believe we need permission to change the source repo on the ros/rosdistro:jazzy/distribution.yaml.
I currently have a PR for a pkg under my github, but with a fork off of your repo, to be used as a place holder, though that hasnt merged yet
I think eventually it would make sense to have all the ros packages under the same repo, especially if you want to update the ros index packages + when you release new mk versions, then it can all be adequately updated. But starting small first makes sense as well
Harrison Saperstein Thanks Harrison, that makes sense. Since the Annin-Robotics repo is now the official repo I’m maintaining and directing users toward, I’d definitely prefer that any ROS Index / rosdistro updates point to https://github.com/Annin-Robotics/ar4_ros_driver rather than a placeholder fork.
I’m open to your help with this, but I’d like to start small and make sure the source repo, package metadata, and release process are handled cleanly before reorganizing everything. The Isaac Sim repo is maintained separately by Ekumen, so for now I think it probably makes sense to keep that separate and cross-link it rather than combine repos.
If you’re able to outline the exact rosdistro changes or open an issue/PR against the Annin-Robotics repo first, that would be a great place to start.
Chris Annin certainly, I just updated my PR to point directly at the AnninRobotics/ar4\_ros\_driver repo and tagged you on it
https://github.com/ros/rosdistro/pull/51618
Yifei Cheng are we able to remove your entry for docs and put it under the annin_robotics repo?
Chris Annin Hey Chris, I opened a PR to the rosdistro to add the a repo to the index, https://github.com/ros/rosdistro/pull/51618. And then submitted a request to make a release team/repo which is needed for storing the release, I believe, https://github.com/ros2-gbp/ros2-gbp-github-org/issues/1042 \<here. Could you please respond to the git issue thread to allow me to help release/maintain this?
something I didnt answer for you was why the ROS index. Well, it allows anyone to install the ROS packages without having to clone and build the repo. It acts on the same ros layer as all the other sudo apt install ros-packages, so that you can more easily provide your packages.
Harrison Saperstein yes I will look at this soon. I just got back from Europe yesterday. Im getting caught up on several orders and emails and will look at this asap.
Hopefully it was a good trip! I really want to go back, only been to Barcelona! And sounds good!
Harrison Saperstein It was mostly for work but not a bad trip. I did respond to the request and merged the 2 requests you sent. Looks great, thank you for your help.